[release/10.0] check ImmedValNeedsReloc in genCreateAddrMode #119757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
Member
|
PTAL @jakobbotsch backport to 10.0 |
jkotas
added
the
area-CodeGen-coreclr
Member
|
Do we need a regression test for this? |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
I was not able to extract a reasonably small repro case out of ZstdSharp (without pinokes/3P), it also seems to be Release only, doesn't repro on Checked. The JIT fix seems to be harmless - it just disables a constant folding for non-relocatable handle + some other const. I suspect it's not the last instance of that problem and we need to refactor the JIT quite a bit, e.g. introduce a special node for constant handles and not re-use general GT_CNS_INT |
This was referenced Sep 16, 2025
Open
rbhanda
added
Servicing-approved
Member
|
PTAL @AndyAyersMS @dotnet/jit-contrib (since Jakob is OOF) |
AndyAyersMS
approved these changes
Sep 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119682 to release/10.0
/cc @EgorBo
Customer Impact
On NativeAOT (and R2R) certain code patterns could produce non-relocatable addresses leading to crashes. The repro involved an RVA + Unsafe.AsPointer pattern.
Regression
Looks like the incorrect logic was introduced many releases ago (in a commit from 2022 it was still there).
Testing
Customer's scenario is tested locally
Risk
Low